Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lean on brave://rewards page for most Rewards settings in brave://settings/rewards #30302

Closed
3 tasks done
Miyayes opened this issue May 12, 2023 · 1 comment · Fixed by brave/brave-core#18483
Closed
3 tasks done

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 12, 2023

Description

We have duplicated many (but not all) Brave Rewards settings into brave://settings/rewards. We should keep some settings there, but remove the bulk of them.

Tasks

image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 1, 2023

Verification PASSED on

Brave | 1.53.76 Chromium: 114.0.5735.90 (Official Build) beta (64-bit)
-- | --
Revision | 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS | Windows 10 Version 22H2 (Build 19045.2965)

Clean profile

1. Rewards enabled

Case 1: Rewards enabled_non connected user state_PASSED
  1. Clean profile 1.53.x
  2. Enable rewards
  3. Don't connect to any custodian
  4. Open brave://settings and click on Brave Rewards left navigation menu
  5. Confirmed that user can see Inline tip settings along with Open full Brave Rewards settings button
  6. Click on the Open full Brave Rewards settings button
  7. Confirm that brave://rewards page is displayed in a new tab when user clicks on the Open full Brave Rewards settings button
Step 5 Step 7
image image
Case 2: Rewards enabled_connected user state_PASSED
  1. Clean profile 1.53.x
  2. Enable rewards
  3. Connect custodian
  4. Open brave://settings and click on Brave Rewards left navigation menu
  5. Confirmed that user can see Inline tip settings along with Open full Brave Rewards settings button
  6. Click on the Open full Brave Rewards settings button
  7. Confirm that brave://rewards page is displayed in new tab with rewards/ads settings, contributions, and monthly contribution sections
  8. Close all the brave://rewards tabs and click on the Open full Brave Rewards settings button via brave://settings/rewards
  9. Confirm that brave://rewards page is displayed in new tab
Step 5 Step 7
image image

2. Rewards not enabled

Users not opted-in to Rewards_PASSED
  1. Clean profile 1.53.x
  2. Don't enable the rewards
  3. Open brave://settings/rewards page
  4. Confirmed that Inline tip settings are displayed
  5. Confirm that Brave rewards is disabled, open brave rewards panel to enable and get started message is displayed
Example Example
image image

Upgrade profile

1. Rewards enabled

Case 1: non connected user upgrade_PASSED
  1. Clean profile 1.52.x
  2. Enable rewrads and don't connect custodian
  3. Upgrade the profile to 1.53.x
  4. Open brave://settings/rewards
  5. Confirmed that user can see Inline tip settings along with Open full Brave Rewards settings button in an upgraded profile
  6. Confirmed that brave://rewards page is displayed when user clicks on the Open full Brave Rewards settings button
  7. Confirmed that Brave Private ads and Maximum numbers ads to display settings are not displayed in an upgraded profile
1.52.x 1.52.x
image image
1.53.x 1.53.x
image image
Case 2: connected user upgrade_PASSED
  1. Clean profile 1.52.x
  2. Enable rewards and connect custodian
  3. Upgrade the profile to 1.53.x
  4. Open brave://settings/rewards
  5. Confirmed that user can see Inline tip settings along with Open full Brave Rewards settings button in an upgraded profile
  6. Click on the Open full Brave Rewards settings button
  7. Confirmed that brave://rewards page is displayed in new tab with rewards/ads settings, contributions, and monthly contribution sections
  8. Confirmed that Brave Private ads, Auto-contribute settings and Maximum numbers of ads to display settings are not displayed in an upgraded profile
1.52.x 1.52.x
image image
1.53.x 1.53.x
image image

2. Rewards not enabled

Users not opted-in to Rewards_PASSED
  1. Clean profile 1.52.x
  2. Don't enable the rewards
  3. Upgrade the profile to 1.53.x
  4. Open brave://settings/rewards page
  5. Confirmed that Inline tip settings are displayed
  6. Confirm that Brave rewards is disabled, open brave rewards panel to enable and get started message is displayed
1.52.x 1.52.x
image image
1.53.x 1.53.x
image image

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants