Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Sardine on for all wallet users #30333

Closed
HEagle18 opened this issue May 15, 2023 · 2 comments · Fixed by brave/brave-core#18499
Closed

Turn Sardine on for all wallet users #30333

HEagle18 opened this issue May 15, 2023 · 2 comments · Fixed by brave/brave-core#18499

Comments

@HEagle18
Copy link

Description

Right now, Sardine is only turned on for US users. We want to turn it on for global wallet users now as well. They recently added global support for cards.

link to discussion -> https://bravesoftware.slack.com/archives/C03FP409W2X/p1683817345044179

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Android specific issue logged #31096. Removing OS/Android label

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jun 16, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified Sardine option is shown for all wallet users and not just restricted to US
30333.mp4

@rebron rebron changed the title Turn on Sardine on for all wallet users Turn Sardine on for all wallet users Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants