Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hide NFTs Tab Feature #30345

Closed
Douglashdaniel opened this issue May 15, 2023 · 1 comment · Fixed by brave/brave-core#18486
Closed

Add Hide NFTs Tab Feature #30345

Douglashdaniel opened this issue May 15, 2023 · 1 comment · Fixed by brave/brave-core#18486
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to a hide NFTs tab checkbox to the Portfolio Settings menu.

  • Unchecking the NFTs tab checkbox should hide the Segmented Control nav on the Portfolio Overview page
  • If the user is on the NFTs tab and unchecks the NFTs tab checkbox, it should also route to the Portfolio Assets page

Screenshot 57
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels May 15, 2023
@Douglashdaniel Douglashdaniel self-assigned this May 15, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 May 15, 2023
@Douglashdaniel Douglashdaniel mentioned this issue May 15, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 May 15, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 May 16, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 16, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Linux
  • Verified steps from brave/brave-core#18486
  • Verified Hide NFT option is available in Portfolio Settings
  • Verified selected state of Hide NFT option is retained between page refresh
  • Verified still able to see NFTs using direct route brave://wallet/crypto/portfolio/nfts when Hide NFT is enabled
30345.mp4

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from brave/brave-core#18486
  • Verified Hide NFT option is available in Portfolio Settings
  • Verified selected state of Hide NFT option is retained between page refresh
  • Verified still able to see NFTs using direct route brave://wallet/crypto/portfolio/nfts when Hide NFT is enabled
30345.mp4

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#18486
  • Verified Hide NFT option is available in Portfolio Settings
  • Verified selected state of Hide NFT option is retained between page refresh
  • Verified still able to see NFTs using direct route brave://wallet/crypto/portfolio/nfts when Hide NFT is enabled
30345.mov

@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Hide NFTs Tab Setting in Portfolio Settings brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds