Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] data is being displayed erroneously in wallet #30354

Closed
kdenhartog opened this issue May 16, 2023 · 3 comments · Fixed by brave/brave-core#18963
Closed

[hackerone] data is being displayed erroneously in wallet #30354

kdenhartog opened this issue May 16, 2023 · 3 comments · Fixed by brave/brave-core#18963
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.56.x - Release

Comments

@kdenhartog
Copy link
Member

See https://hackerone.com/reports/1988349
@kdenhartog kdenhartog added security priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels May 16, 2023
@onyb onyb self-assigned this May 31, 2023
@onyb onyb mentioned this issue Jun 19, 2023
Merged
25 tasks
@onyb onyb added this to Web3 Jun 19, 2023
@onyb onyb moved this to In Review in Web3 Jun 19, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 20, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 20, 2023
@onyb onyb mentioned this issue Jun 21, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.53.103 or higher for 1.53.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit)
Revision 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS Windows 11 Version 22H2 (Build 22621.1848)
30354.mp4

@srirambv
Copy link
Contributor

Changes are backend only. Discussed with @onyb and verification on desktop is sufficient. Removing OS/Android label so it doesn't list on pending verifications for Android.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jun 27, 2023
@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): remove extra fields from eth_signTypedData_v4 message brave/brave-core
5 participants
@kjozwiak @onyb @srirambv @kdenhartog @brave-builds