Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Help Centre link to beside 'Privacy Policy' on Swaps and change link destination #30372

Closed
HEagle18 opened this issue May 16, 2023 · 2 comments · Fixed by brave/brave-core#18739
Closed

Add Help Centre link to beside 'Privacy Policy' on Swaps and change link destination #30372

HEagle18 opened this issue May 16, 2023 · 2 comments · Fixed by brave/brave-core#18739
Assignees
@muliswilliam
Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@HEagle18
Copy link

Description

Right now, we want to move the help centre link out of the network dropdown and put it beside 'privacy policy'. It should also link to https://support.brave.com/hc/en-us/categories/360001059151-Brave-Wallet rather than the wallet FAQs. This needs to be changed on android too.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@HEagle18 HEagle18 added OS/Android Fixes related to Android browser functionality OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/swap labels May 16, 2023
@HEagle18 HEagle18 added this to Web3 May 16, 2023
@HEagle18 HEagle18 assigned HEagle18 and muliswilliam and unassigned HEagle18 May 16, 2023
@muliswilliam muliswilliam mentioned this issue May 18, 2023
Closed
@muliswilliam muliswilliam moved this to In Review in Web3 May 18, 2023
@muliswilliam muliswilliam mentioned this issue Jun 2, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 6, 2023
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Jun 6, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 6, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.57.18 x64 Beta build

  • Verified steps from brave/brave-core#18739
  • Verified Help Centre link is shown next to the Privacy Policy link on Swap screen
  • Verified Help Centre links to https://support.brave.com/hc/en-us/categories/360001059151-Brave-Wallet
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
30372-ARM.mp4
30372-Tab.mp4

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.57.23 Chromium: 115.0.5790.102 (Official Build) beta (64-bit)
Revision d515871a6c6df7d2843e755c8b7dda9b744f26d6
OS Linux
  • Verified steps from brave/brave-core#18739
  • Verified Help Centre link is shown next to the Privacy Policy link on Swap screen
  • Verified Help Centre links to https://support.brave.com/hc/en-us/categories/360001059151-Brave-Wallet
30372.mp4

Verification passed on

Brave 1.57.23 Chromium: 115.0.5790.102 (Official Build) beta (64-bit)
Revision d515871a6c6df7d2843e755c8b7dda9b744f26d6
OS Windows 11 Version 22H2 (Build 22621.1992)
  • Verified steps from brave/brave-core#18739
  • Verified Help Centre link is shown next to the Privacy Policy link on Swap screen
  • Verified Help Centre links to https://support.brave.com/hc/en-us/categories/360001059151-Brave-Wallet
30372.mp4

Verification passed on

Brave 1.57.23 Chromium: 115.0.5790.102 (Official Build) beta (64-bit)
Revision d515871a6c6df7d2843e755c8b7dda9b744f26d6
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#18739
  • Verified Help Centre link is shown next to the Privacy Policy link on Swap screen
  • Verified Help Centre links to https://support.brave.com/hc/en-us/categories/360001059151-Brave-Wallet
30372.mov

@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
4 participants
@HEagle18 @srirambv @brave-builds @muliswilliam