Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BraveVPN connection when uninstalling the browser #30416

Closed
spylogsster opened this issue May 17, 2023 · 4 comments · Fixed by brave/brave-core#18529
Closed

Remove BraveVPN connection when uninstalling the browser #30416

spylogsster opened this issue May 17, 2023 · 4 comments · Fixed by brave/brave-core#18529

Comments

@spylogsster
Copy link

Description

Removed browser but brave vpn connection still work and able to connect.

Steps to Reproduce

  1. Install Brave
  2. Enable and connect BraveVpn
  3. Uninstall browser from windows

Actual result:

Vpn connection can be used from system after uninstalling.

Expected result:

Vpn connection should be removed with the browser.

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@spylogsster
Copy link
Author

cc @bsclifton @rebron

@stephendonner
Copy link

stephendonner commented May 17, 2023

@stephendonner
Copy link

stephendonner commented May 31, 2023

Verification PASSED using

Brave | 1.53.75 Chromium: 114.0.5735.58 (Official Build) beta (64-bit) 
Revision | ef012197ab4bc867d7b1dd80a001d0be7da8a714-refs/branch-heads/5735_52@{#7}
OS | Windows 10 Version 22H2 (Build 19045.3031)

Steps:

  1. removed any/all BraveVPN connections from previous testing
  2. installed 1.53.75
  3. launched Brave
  4. purchased, configured, and connected to BraveVPN
  5. confirmed BraveVPNBeta entry in Settings -> Network & Internet -> VPN
  6. ran browserleaks.com/dns to confirm both connection to VPN (Datacamp), without DNS leaks (Cloudflare)
  7. clicked Uninstall via the Brave Beta entry on Uninstall or change a program in Control Panel -> Programs -> Programs and Features
  8. selected Also delete your browsing data in the Uninstall Brave dialog
  9. clicked Uninstall
  10. confirmed Brave VPN is removed in Apps & Features / Control Panel menus
  11. confirmed Microsoft Edge loaded brave.com on uninstall (usually used for Uninstall Survey)
  12. confirmed BraveVPNBeta is removed from the VPN panel in Network & Internet
  13. also confirmed BraveVPN* entries were removed, using the Registry Editor
example example example example
image image (1) image (2) image (3)
example example example example example
image (5) image (6) image (8) image (9) image (10)

@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 31, 2023
@MadhaviSeelam
Copy link

Verification PASSED

Brave | 1.53.75 Chromium: 114.0.5735.58 (Official Build) beta (64-bit)
-- | --
Revision | ef012197ab4bc867d7b1dd80a001d0be7da8a714-refs/branch-heads/5735_52@{#7}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Steps:

  1. removed any/all BraveVPN connections from previous testing
  2. installed 1.53.75
  3. launched Brave
  4. purchased, configured, and connected to BraveVPN
  5. confirmed BraveVPNBeta entry in Settings -> Network & Internet -> VPN
  6. ran browserleaks.com/dns to confirm both connection to VPN (Datacamp), without DNS leaks (Cloudflare)
  7. clicked Uninstall via the Brave Beta entry on Uninstall or change a program in Control Panel -> Programs -> Programs and Features
  8. selected Also delete your browsing data in the Uninstall Brave dialog
  9. clicked Uninstall
  10. confirmed Brave VPN is removed in Installed apps / Control Panel menus
  11. confirmed Microsoft Edge loaded brave.com on uninstall (usually used for Uninstall Survey)
  12. confirmed BraveVPNBeta is removed from the VPN panel in Network & Internet
  13. also confirmed BraveVPN* entries were removed, using the Registry Editor
step 1 step 4 step 5 step 6 step 9 step 10 step 11 step 12 step 13
image image image image image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment