Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Portfolio Settings to use Toggles #30422

Closed
Douglashdaniel opened this issue May 18, 2023 · 1 comment · Fixed by brave/brave-core#18540
Closed

Update Portfolio Settings to use Toggles #30422

Douglashdaniel opened this issue May 18, 2023 · 1 comment · Fixed by brave/brave-core#18540
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to update the Portfolio settings to use toggle switches instead of checkboxes

Screenshot 59
@Douglashdaniel Douglashdaniel added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels May 18, 2023
@Douglashdaniel Douglashdaniel self-assigned this May 18, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 May 18, 2023
@Douglashdaniel Douglashdaniel mentioned this issue May 19, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 May 19, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 May 19, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 19, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit)
Revision 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS Linux
30422.mp4

Verification passed on

Brave 1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit)
Revision 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS Windows 11 Version 22H2 (Build 22621.1848)
30422.mp4

Verification passed on

Brave 1.53.104 Chromium: 115.0.5790.40 (Official Build) (64-bit)
Revision 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS macOS Version 13.0 (Build 22A380)
30422.mov

@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Use Toggles in Portfolio Settings brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds