Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out Portfolio Filters and Display Settings Modal #30496

Closed
Douglashdaniel opened this issue May 22, 2023 · 1 comment · Fixed by brave/brave-core#18727
Closed

Build out Portfolio Filters and Display Settings Modal #30496

Douglashdaniel opened this issue May 22, 2023 · 1 comment · Fixed by brave/brave-core#18727
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to build out the Portfolio Filters and Display Settings modal

Screenshot 3
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels May 22, 2023
@Douglashdaniel Douglashdaniel self-assigned this May 22, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 May 22, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Jun 2, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jun 2, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 6, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 6, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.57.24 Chromium: 115.0.5790.136 (Official Build) beta (64-bit)
Revision 8099932ede6f8d4624fbddf39d27abb3b340d8c9
OS Linux
  • Verified steps from brave/brave-core#18727
  • Verified able to group assets by Accounts(default), Networks and None
  • Verified grouping assets by Accounts shows all the tokens in the account
  • Verified grouping assets by Networks groups tokens from all accounts and groups it based on network
  • Verified grouping assets set to None shows all tokens as a single list
  • Verified setting Sort assets to High to Low orders the tokens in descending order of balance/value
  • Verified setting Sort assets to Low to High orders the tokens in ascending order of balance/value
  • Verified setting Sort assets to A to Z orders the tokens in alphabetical order
  • Verified setting Sort assets to Z to A orders the tokens in reverse alphabetical order
  • Verified able to filter accounts based on network.
  • Verified able to filter list based on accounts
  • Verified Hide small balances when enabled hides all tokens from all accounts/networks which has value < $1
Group by Sort Assets Hide small balance Network filter Account filter
30496-Group.by.mp4
30496-Sort.Asset.mp4
30496-Small.Balance.mp4
30496-Select.Network.mp4
30496-Select.Account.mp4

Verification passed on

Brave 1.57.24 Chromium: 115.0.5790.136 (Official Build) beta (64-bit)
Revision 8099932ede6f8d4624fbddf39d27abb3b340d8c9
OS Windows 11 Version 22H2 (Build 22621.1992)
  • Verified steps from brave/brave-core#18727
  • Verified able to group assets by Accounts(default), Networks and None
  • Verified grouping assets by Accounts shows all the tokens in the account
  • Verified grouping assets by Networks groups tokens from all accounts and groups it based on network
  • Verified grouping assets set to None shows all tokens as a single list
  • Verified setting Sort assets to High to Low orders the tokens in descending order of balance/value
  • Verified setting Sort assets to Low to High orders the tokens in ascending order of balance/value
  • Verified setting Sort assets to A to Z orders the tokens in alphabetical order
  • Verified setting Sort assets to Z to A orders the tokens in reverse alphabetical order
  • Verified able to filter accounts based on network.
  • Verified able to filter list based on accounts
  • Verified Hide small balances when enabled hides all tokens from all accounts/networks which has value < $1
Group by Sort Assets Hide small balance Network filter Account filter
30496-Group.By.mp4
30496-Sort.Assets.mp4
30496-Small.Balances.mp4
30496-Select.Network.mp4
30496-Select.Account.mp4

Verification passed on

Brave 1.57.24 Chromium: 115.0.5790.136 (Official Build) beta (arm64)
Revision 8099932ede6f8d4624fbddf39d27abb3b340d8c9
OS macOS Version 13.4.1 (c) (Build 22F770820d)
  • Verified steps from brave/brave-core#18727
  • Verified able to group assets by Accounts(default), Networks and None
  • Verified grouping assets by Accounts shows all the tokens in the account
  • Verified grouping assets by Networks groups tokens from all accounts and groups it based on network
  • Verified grouping assets set to None shows all tokens as a single list
  • Verified setting Sort assets to High to Low orders the tokens in descending order of balance/value
  • Verified setting Sort assets to Low to High orders the tokens in ascending order of balance/value
  • Verified setting Sort assets to A to Z orders the tokens in alphabetical order
  • Verified setting Sort assets to Z to A orders the tokens in reverse alphabetical order
  • Verified able to filter accounts based on network.
  • Verified able to filter list based on accounts
  • Verified Hide small balances when enabled hides all tokens from all accounts/networks which has value < $1
Group by Sort Assets Hide small balance Network filter Account filter
30496-Group.by.mov
30496-Sort.Asset.mov
30496.-Small.Balance.mov
30496-Select.Network.mov
30496-Select.Account.mov

@srirambv srirambv mentioned this issue Jul 27, 2023
Closed
@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Portfolio Filters and Display Settings brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds