Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of balance lookups in the panel #30772

Closed
onyb opened this issue Jun 2, 2023 · 0 comments · Fixed by brave/brave-core#18735
Closed

Improve performance of balance lookups in the panel #30772

onyb opened this issue Jun 2, 2023 · 0 comments · Fixed by brave/brave-core#18735
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop perf QA/No release-notes/include
Milestone
1.57.x - Release

Comments

@onyb
Copy link
Member

onyb commented Jun 2, 2023

The panel can be extremely slow when the wallet has a lot of accounts. One reason for this is that we do a lot of wasteful balance lookups in an indiscriminate fashion, and that too every 15s. On top of that, the balance queries spawn a lot of concurrent HTTP requests, frequently resulting in 100% CPU usage.
@onyb onyb added QA/No perf release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 2, 2023
@onyb onyb self-assigned this Jun 2, 2023
@onyb onyb added this to Web3 Jun 2, 2023
@onyb onyb mentioned this issue Jun 2, 2023
Merged
25 tasks
@onyb onyb moved this to In Review in Web3 Jun 2, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 7, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 7, 2023
@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop perf QA/No release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

chore(wallet): improve panel performance brave/brave-core
2 participants
@onyb @brave-builds