Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide/Unhide NFT's is making unnecessary price history calls #30925

Closed
Douglashdaniel opened this issue Jun 8, 2023 · 1 comment · Fixed by brave/brave-core#18828
Closed

Hide/Unhide NFT's is making unnecessary price history calls #30925

Douglashdaniel opened this issue Jun 8, 2023 · 1 comment · Fixed by brave/brave-core#18828
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/include
Milestone
1.57.x - Release

Comments

@Douglashdaniel
Copy link

Description

Hide/Unhide NFT's is making unnecessary price history calls causing the Portfolio balance to change.

Steps to Reproduce

  1. Go to the NFT's tab and Hide/Unhide some nft's
  2. Price history will change sometimes.

Actual result:

Screen.Recording.7.mov

Expected result:

We shouldn't need to update price history when hiding or unhiding nft's

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 8, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jun 8, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jun 8, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Jun 8, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jun 8, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 9, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 9, 2023
@srirambv
Copy link
Contributor

@Douglashdaniel think this is still happening as the price change happens when I hide/unhide NFTs

brave_y1W2mPpruj.mp4

@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Don't refresh prices when hiding NFTs brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds