Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported hardware wallet options menu is not fully shown #30939

Closed
srirambv opened this issue Jun 9, 2023 · 1 comment · Fixed by brave/brave-core#18868
Closed

Imported hardware wallet options menu is not fully shown #30939

srirambv opened this issue Jun 9, 2023 · 1 comment · Fixed by brave/brave-core#18868
Assignees
Labels
design A design change, especially one which needs input from the design team feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 9, 2023

Description

Imported hardware wallet options menu is not fully shown

Steps to Reproduce

  1. Import a couple of HW wallet accounts
  2. Click on the three dot menu
  3. When the list is big the menu is shown but the right side of the menu is overlapping on the border of the frame
  4. When the list is small the menu opens up but doesn't auto scroll down to show the full options, making it look like its bugged

Actual result:

Screenshot 2023-06-09 at 6 17 06 AM Screenshot 2023-06-09 at 6 17 46 AM

Expected result:

Should show the menu so that there is no need to scroll and probably add more padding to the right to highlight the edges on the right

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.53.74 Chromium: 114.0.5735.53 (Official Build) beta (arm64)
Revision c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @supermassive @Douglashdaniel @kleantzogu

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jun 9, 2023
@srirambv srirambv added this to Web3 Jun 9, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jun 9, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jun 9, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Jun 9, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jun 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 12, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 12, 2023
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.57.27 Chromium: 115.0.5790.1314 (Official Build) beta (64-bit)
Revision 18977fb43f693d5a8deeb48bd1cfa52651d3f73e
OS Windows 11 Version 22H2 (Build 22621.1992)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants