Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto discover POAPs #30977

Closed
nvonpentz opened this issue Jun 12, 2023 · 1 comment · Fixed by brave/brave-core#18886
Closed

Auto discover POAPs #30977

nvonpentz opened this issue Jun 12, 2023 · 1 comment · Fixed by brave/brave-core#18886
Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@nvonpentz
Copy link
Member

Based on SimpleHash's docs, we should be able to do this using the same endpoint that we discover NFTs from by supplying a specific contract address:

If you need to query POAPs for a specific wallet, use the NFTs by Wallet(s) endpoint instead and filter for 0x22C1f6050E56d2876009903609a2cC3fEf83B415 in the contract_addresses field.
@nvonpentz nvonpentz added this to Web3 Jun 12, 2023
@nvonpentz nvonpentz mentioned this issue Jun 13, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this to Done in Web3 Jun 16, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 16, 2023
@srirambv
Copy link
Contributor

srirambv commented Aug 7, 2023

Verification passed on

Brave 1.57.35 Chromium: 115.0.5790.171 (Official Build) beta (arm64)
Revision 776897328898241b35b83878040730e73e749c06
OS macOS Version 13.4.1 (c) (Build 22F770820d)
  • Verified steps from brave/brave-core#18886
  • Verified POAPs are auto discovered when the supported network is preloaded
  • Verified POAPs are auto discovered on an existing wallet when the supported network is added and manually refreshed
30977.mov

@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Auto discover NFTs on custom networks brave/brave-core
3 participants
@nvonpentz @srirambv @brave-builds