Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset Details Back button breaks when coming from Panel #30995

Closed
Douglashdaniel opened this issue Jun 12, 2023 · 1 comment · Fixed by brave/brave-core#18875
Closed

Asset Details Back button breaks when coming from Panel #30995

Douglashdaniel opened this issue Jun 12, 2023 · 1 comment · Fixed by brave/brave-core#18875
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Jun 12, 2023 •
edited
Loading

Description

If you expand to the Asset Details view from the panel, the back button breaks the UI

Steps to Reproduce

  1. Open the Panel and click on View account assets, select an asset.
  2. Once the Asset Details page loads, click on the Back button in the header
  3. The wallet UI breaks

Actual result:

Screen.Recording.17.mov

Expected result:

Should route back to an appropriate route.

Screen.Recording.18.mov

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 12, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jun 12, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jun 12, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Jun 12, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jun 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 13, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 13, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.57.24 Chromium: 115.0.5790.136 (Official Build) beta (64-bit)
Revision 8099932ede6f8d4624fbddf39d27abb3b340d8c9
OS Linux
  • Verified steps from brave/brave-core#18875
  • Verified selecting asset from panel and clicking on back button loads the portfolio asset page
  • Verified selecting NFT from panel and clicking on back button loads the portfolio NFT page
30995.mp4

Verification passed on

Brave 1.57.24 Chromium: 115.0.5790.136 (Official Build) beta (64-bit)
Revision 8099932ede6f8d4624fbddf39d27abb3b340d8c9
OS Windows 11 Version 22H2 (Build 22621.1992)
  • Verified steps from brave/brave-core#18875
  • Verified selecting asset from panel and clicking on back button loads the portfolio asset page
  • Verified selecting NFT from panel and clicking on back button loads the portfolio NFT page
30995.mp4

Verification passed on

Brave 1.57.24 Chromium: 115.0.5790.136 (Official Build) beta (arm64)
Revision 8099932ede6f8d4624fbddf39d27abb3b340d8c9
OS macOS Version 13.4.1 (c) (Build 22F770820d)
  • Verified steps from brave/brave-core#18875
  • Verified selecting asset from panel and clicking on back button loads the portfolio asset page
  • Verified selecting NFT from panel and clicking on back button loads the portfolio NFT page
30995.mov

@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Asset Details Back Button from Panel brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds