Login issue on live.com

[pilgrim-brave]

(selected snippets from Slack conversation)

Hello, on https://login.live.com/, the site doesn’t load browser language setting(brave://settings/languages) if Prevent sites from fingerprinting me based on my language is enabled on brave://settings/shields. If the setting is enabled, the site is shown in English even if I set Japanese on the language setting. But the site is shown in Japanese if I turn off that setting. I have a user who would like to see the site in Japanese with Shields enabled.

I can reproduce the issue with non-aggressive mode(standard shields setting).

might be good to hardcode an exception then for uplift, and then bite the bullet and add a component so we can handle going forward

[pilgrim-brave]

@pes10k @A-t-s-u-s-h-i @ryanbr

[kjozwiak]

The above requires 1.53.106 or higher for 1.53.x verification 👍

[MadhaviSeelam]

Verification In progress using

Brave | 1.53.107 Chromium: 115.0.5790.40 (Official Build) (64-bit)
-- | --
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS | Windows 11 Version 22H2 (Build 22621.1848)

Reproduced the issue in 1.52.129 Chromium: 114.0.5735.198

example	example

Case 1: Site translated to Japanese when locale settings changed to Japanese Japan in OS

1. Install 1.53.107
2. change the locale to Japan in OS settings
3. launched Brave
4. opened brave://settings/languages
5. select Japanese
6. visit https://login.live.com/

Confirmed https://login.live.com sign in site is translated in selected language Japanese

example	example

Case 2: set browser language settings to Japanese when Prevent sites from fingerprinting me based on my language preferences is enabled

1.new profile
2. launched Brave
3. opened brave://settings/languages
4. Added Japanese
5. open brave://settings/shields
6. verified Prevent sites from fingerprinting me based on my language preferences is enabled
7. visit https://login.live.com/
8. visited another website (https://instagram.com) and ensured that Accept-Language only lists a single language (ja)

####Confirmed https://login.live.com sign in site is translated in selected language Japanese

step 4	step 6	step 7

Case 3: set browser language settings Japanese when Prevent sites from fingerprinting me based on my language preferences is disabled

1. continue from Case 2
   • brave://settings/languages shows Japanese
2. opened brave://settings/shields
3. disabled Prevent sites from fingerprinting me based on my language preferences
4. visit https://login.live.com/

Confirmed https://login.live.com sign in site is translated in selected language Japanese

step 3	step 3	step 5

Case 4: Browser language setting - English (United Kingdom)
(Also ensured that the following STR/Cases worked as expected as per @pes10k)

1. continuing from case 3
2. added several languages into brave://settings/languages ( English (India), Chinese (Hong Kong),Belarusian,Telugu)
3. verified that Prevent sites from fingerprinting me based on my language preferences is enabled
4. visited https://dev-pages.brave.software/fingerprinting/headers.html and ensured that Accept-Language only listed a single language (en-GB)
5. visited http://login.live.com end ensured that Accept-Language displays/lists all the languages that were added
   • • this is due to the exception being added in this PR
6. visited another website (https://instagram.com) and ensure that Accept-Language only lists a single language (en-GB)
7. disabled the shields on https://instagram.com)

Confirmed that all the languages will be listed via Accept-Language due to farbling being disabled

step 2	step 3	step 4	step 5	step 6	step 8

[Uni-verse]

Verified on Samsung Galaxy S21 using the following version(s):

Brave	1.56.3 Chromium: 115.0.5790.75 (Official Build) (64-bit) 
Revision	3433e4d513e8454ba0243deea3d53693661dc0c3-refs/branch-heads/5790@{#1430}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Case 1: OS settings

• Verified page is translated on clean profile based on OS language preferences when viewing https://login.live.com.
• Verified user is page able to translate page using the toolbar.

Example	Example

Case 2: Brave preferred language

• Verified login.live.com is translated when making Japanese preferred language in settings

Case 3: Accept Languages

• Verified all languages are listed under Accept-Language in the headers for login.live.com
• Verified only single language is listed other other sites

live.com	other site