Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TREZOR Password Manager extension is not working with Google Drive #3120

Open
LubosVoska opened this issue Jan 26, 2019 · 8 comments
Open

TREZOR Password Manager extension is not working with Google Drive #3120

LubosVoska opened this issue Jan 26, 2019 · 8 comments
Labels
feature/extensions needs-more-info The report requires more detail before we can decide what to do with this issue.

Comments

@LubosVoska
Copy link

LubosVoska commented Jan 26, 2019

Description

TREZOR Password Manager extension is not working with Google Drive

Steps to Reproduce

  1. Open TREZOR Password Manager extension
  2. Try sign in with Google drive

Actual result:

image

Expected result:

Possible sign in with Google Drive

Brave version (brave://version info)

Brave | 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Windows

@srirambv
Copy link
Contributor

Can you try allowing all cookies from shields and check if it fixes the issue?

@srirambv srirambv added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Jan 28, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 28, 2019
@LubosVoska
Copy link
Author

I tried but sign in is not working.

image

@ernest22
Copy link

ernest22 commented Feb 1, 2019

Same issue for months

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@kjozwiak
Copy link
Member

I'm sure this is due to us disabling the WebUSB API in 0.55.x brave/brave-core#114. When you have the Trezor connected via USB and open the extension, you'll get the following errors in the console when listening to the background pages:

iframe.9b57ae6d349fd314f512.js:8 [trezor-link] Error in WebUsbPlugin.init Error: WebUSB is not available on this browser.
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at _ (iframe.9b57ae6d349fd314f512.js:8)
    at Generator._invoke (iframe.9b57ae6d349fd314f512.js:8)
    at Generator.e.(connect.trezor.io/6/anonymous function) [as next] (https://connect.trezor.io/6/js/iframe.9b57ae6d349fd314f512.js:8:126598)
    at n (iframe.9b57ae6d349fd314f512.js:59)
    at iframe.9b57ae6d349fd314f512.js:59
    at new Promise (<anonymous>)
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at e.r.value (iframe.9b57ae6d349fd314f512.js:8)
iframe.9b57ae6d349fd314f512.js:8 [trezor-link] Error in LowlevelTransportWithSharedConnections.init Error: WebUSB is not available on this browser.
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at _ (iframe.9b57ae6d349fd314f512.js:8)
    at Generator._invoke (iframe.9b57ae6d349fd314f512.js:8)
    at Generator.e.(connect.trezor.io/6/anonymous function) [as next] (https://connect.trezor.io/6/js/iframe.9b57ae6d349fd314f512.js:8:126598)
    at n (iframe.9b57ae6d349fd314f512.js:59)
    at iframe.9b57ae6d349fd314f512.js:59
    at new Promise (<anonymous>)
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at e.r.value (iframe.9b57ae6d349fd314f512.js:8)
[trezor-link] Error in ParallelTransport.init Error: WebUSB is not available on this browser.
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at _ (iframe.9b57ae6d349fd314f512.js:8)
    at Generator._invoke (iframe.9b57ae6d349fd314f512.js:8)
    at Generator.e.(connect.trezor.io/6/anonymous function) [as next] (https://connect.trezor.io/6/js/iframe.9b57ae6d349fd314f512.js:8:126598)
    at n (iframe.9b57ae6d349fd314f512.js:59)
    at iframe.9b57ae6d349fd314f512.js:59
    at new Promise (<anonymous>)
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at e.<anonymous> (iframe.9b57ae6d349fd314f512.js:59)
    at e.r.value (iframe.9b57ae6d349fd314f512.js:8)

Typing in navigator.usb will result in an undefined. What should be happening is that once you click on "Sign in with Drive", a new window should appear that lets you login into Google. This is working fine on Chrome.

@kjozwiak kjozwiak removed their assignment Feb 27, 2019
@brianddk
Copy link

Could WebUSB enablement be added as a chrome://flags feature. I can understand why it should be off by default, but allowing users to control the feature would be helpful for any sites / products that rely on WebUSB.

@pagarces
Copy link

pagarces commented Jun 1, 2019

until we can be loged using Drive on Brave is not gonna work.

@brianddk
Copy link

brianddk commented Jun 1, 2019

until we can be loged using Drive on Brave is not gonna work.

I thought the assumption here was that the missing Drive-Signin-Dialog was a cascading error originating from the disablement of WebUSB, which is required for the Trezor workflow.

@kjozwiak
Copy link
Member

WebUSB was enabled via #4669 which unfortunately didn't fix the above issue. Using Dropbox for authentication works correctly but still seems broken when using Google Drive as authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/extensions needs-more-info The report requires more detail before we can decide what to do with this issue.
Projects
Status: Needs Info
Development

No branches or pull requests

7 participants