Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some items on brave://settings/system/shortcuts have unexpected appearance #33389

Open
LaurenWags opened this issue Oct 3, 2023 · 1 comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

See discussion under https://bravesoftware.slack.com/archives/CKNHM4RTK/p1696348190459129

Generally some items under brave://settings/system/shortcuts appear differently than they do in 1.58.x.

Steps to Reproduce

  1. Compare brave://settings/system/shortcuts on 1.58.x and 1.59.x

Actual result:

examples:

  • search box is darker on 1.58.x
  • color of keyboard buttons differs (higher contrast in 1.59.x)
  • possible font/weight differences
  • etc

1.59.x
1 59

Expected result:

1.58.x (or as directed by design team)
1 58

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.59.109 Chromium: 118.0.5993.21 (Official Build) beta (x86_64)
-- | --
Revision | aacb6a6f8bd916bd49f064b2137b007fa6c47b51
OS | macOS Version 13.6 (Build 22G120)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.58.x no
  • Can you reproduce this issue with the beta channel? 1.59.x yes
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @aguscruiz

@LaurenWags LaurenWags added design A design change, especially one which needs input from the design team QA/Yes OS/Desktop labels Oct 3, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 3, 2023

Reproduced the issue in Linux & Windows 11

1.59.109 Chromium: 118.0.5993.21 (Official Build) beta (64-bit) 
Revision	aacb6a6f8bd916bd49f064b2137b007fa6c47b51
OS	Linux
1.59.109 Chromium: 118.0.5993.21 1.58.122 Chromium: 117.0.5938.62
image image

@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to Untriaged Backlog in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop QA/Yes
Projects
Status: Untriaged Backlog
Development

No branches or pull requests

2 participants