Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 118.0.5993.32 to Chromium 118.0.5993.54 #33423

Closed
emerick opened this issue Oct 4, 2023 · 8 comments · Fixed by brave/brave-core#20402
Closed

Upgrade from Chromium 118.0.5993.32 to Chromium 118.0.5993.54 #33423

emerick opened this issue Oct 4, 2023 · 8 comments · Fixed by brave/brave-core#20402
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Milestone
1.59.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Oct 4, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/118.0.5993.32..118.0.5993.54?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Oct 4, 2023
This was referenced Oct 4, 2023
Merged
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Oct 5, 2023

Quick overview of the work remaining re: affected areas due to C118 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #32933 (comment):

Platforms that still need to check/verify the affected areas due to C118 changes as per #32933 (comment):

  • N/A (all platforms went through the affected areas and only require a shot check)

@kjozwiak
Copy link
Member

kjozwiak commented Oct 5, 2023

The above requires 1.59.112 or higher for 1.59.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.59.112 Chromium: 118.0.5993.54 (Official Build) (64-bit)
-- | --
Revision | 967f25f295938c64c24e2e6a1790470668757655
OS | Windows 10 Version 22H2 (Build 19045.3448)

image

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 5, 2023
@LaurenWags
Copy link
Member

Verified with

Brave | 1.59.112 Chromium: 118.0.5993.54 (Official Build) (x86_64)
-- | --
Revision | 967f25f295938c64c24e2e6a1790470668757655
OS | macOS Version 13.6 (Build 22G120)
Intel

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 5, 2023
@hffvld
Copy link
Contributor

hffvld commented Oct 5, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B1.230908.003 release-keys]
Brave build: 1.59.112
Chromium: 118.0.5993.54 (Official Build) (64-bit) 
Revision: 967f25f295938c64c24e2e6a1790470668757655
1 2
1 2

@hffvld
Copy link
Contributor

hffvld commented Oct 5, 2023

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.59.112
Chromium: 118.0.5993.54 (Official Build) (64-bit) 
Revision: 967f25f295938c64c24e2e6a1790470668757655
1 2
1 2

This was referenced Oct 5, 2023
Closed
Closed
@btlechowski
Copy link

Verified PASSED

Brave 1.59.115 Chromium: 118.0.5993.54 (Official Build) (64-bit)
Revision 82b05012fc6b5ab8535cf283db6856ad5eedd7eb
OS Linux

image

@LaurenWags
Copy link
Member

Updating to QA/No and release-notes/exclude as this is superseded by #33556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 118.0.5993.32 to Chromium 118.0.5993.54 brave/brave-core
8 participants
@kjozwiak @emerick @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin @brave-builds @hffvld