Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts Tab is showing $0.00 briefly before return #33993

Closed
Douglashdaniel opened this issue Oct 30, 2023 · 1 comment · Fixed by brave/brave-core#20740
Closed

Accounts Tab is showing $0.00 briefly before return #33993

Douglashdaniel opened this issue Oct 30, 2023 · 1 comment · Fixed by brave/brave-core#20740
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Description

The Accounts tab is showing $0.00 for account fiat values briefly before the actual fiat value is returned

Steps to Reproduce

  1. Open the Wallet and navigate to the Accounts tab
  2. The fiat value for every account will show $0.00 value briefly before actually value is returned

Actual result:

Screen.Recording.14.mov

Expected result:

Should continue to show the Loading Skeleton until we the actual fiat value is returned.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Oct 30, 2023
@Douglashdaniel Douglashdaniel self-assigned this Oct 30, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Oct 30, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Oct 30, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Oct 30, 2023
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Oct 30, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS Windows 11 Version 23H2 (Build 22631.2861)
  • Verified steps from
  • Verified accounts tab doesn't show $0.00 when balance is being fetched
33993.mp4

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS Linux
  • Verified steps from
  • Verified accounts tab doesn't show $0.00 when balance is being fetched
33993.mp4

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (arm64)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS macOS Version 14.2.1 (Build 23C71)
  • Verified steps from
  • Verified accounts tab doesn't show $0.00 when balance is being fetched
33993.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants