Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet Account Icon Stack missing Dark Theme Text Color #34093

Closed
Douglashdaniel opened this issue Nov 3, 2023 · 1 comment · Fixed by brave/brave-core#20833
Closed

Wallet Account Icon Stack missing Dark Theme Text Color #34093

Douglashdaniel opened this issue Nov 3, 2023 · 1 comment · Fixed by brave/brave-core#20833
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@Douglashdaniel
Copy link

Description

The Icon Stack for accounts on the Accounts tab is missing Dark Theme color for the text

Steps to Reproduce

  1. Go to the Accounts tab and look at your list of accounts that have tokens
  2. The Text for the additional Tokens in the Icon Stack does not have a Dark Theme color

Actual result:

Screenshot 47

Expected result:

Screenshot 48

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 3, 2023
@Douglashdaniel Douglashdaniel self-assigned this Nov 3, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 3, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Nov 3, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 3, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Nov 3, 2023
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 3, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS Windows 11 Version 23H2 (Build 22631.2861)

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS Linux

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (arm64)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS macOS Version 14.2.1 (Build 23C71)

@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Icon Stack Text Color brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds