Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Initial Shadow in the Wallet Panel Header #34319

Closed
Douglashdaniel opened this issue Nov 14, 2023 · 1 comment · Fixed by brave/brave-core#20973
Closed

Hide Initial Shadow in the Wallet Panel Header #34319

Douglashdaniel opened this issue Nov 14, 2023 · 1 comment · Fixed by brave/brave-core#20973
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Description

There is an initial shadow that is displayed in the Wallet Panel header on first Panel launch.

Steps to Reproduce

  1. Open the Wallet Panel
  2. There is an initial shadow that is displayed in the header

Actual result:

image

Expected result:

There should not be an initial shadow, the shadow should only appear when the users scrolls down.

Screenshot 13

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Douglashdaniel Douglashdaniel added bug polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 14, 2023
@Douglashdaniel Douglashdaniel self-assigned this Nov 14, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 14, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Nov 14, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Nov 15, 2023
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 15, 2023
@srirambv
Copy link
Contributor

srirambv commented Jan 3, 2024

Verification passed on

Brave 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
Revision 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS Windows 11 Version 22H2 (Build 22621.2506)

Verification passed on

Brave 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
Revision 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS Linux

Verification passed on

Brave 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (arm64)
Revision 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS macOS Version 14.2.1 (Build 23C71)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants