Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Page Settings Button Style #36267

Closed
Douglashdaniel opened this issue Feb 21, 2024 · 1 comment · Fixed by brave/brave-core#22216
Closed

Update Page Settings Button Style #36267

Douglashdaniel opened this issue Feb 21, 2024 · 1 comment · Fixed by brave/brave-core#22216
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to update the Page Settings button style to be squared to match the new designs in figma

Expected result:

Screenshot 27

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 21, 2024
@Douglashdaniel Douglashdaniel self-assigned this Feb 21, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Feb 21, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Feb 21, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Feb 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 22, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 22, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.65.89 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
Revision 2975bd8d3905ed79de82dd9fa11b6e4019075dd6
OS Windows 11 Version 23H2 (Build 22631.3296)
36267.mp4

@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Page Settings Button Style brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds