Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using LiFi Quote in Swap #36436

Closed
StephenHeaps opened this issue Feb 28, 2024 · 2 comments · Fixed by brave/brave-core#23731
Closed

Support using LiFi Quote in Swap #36436

StephenHeaps opened this issue Feb 28, 2024 · 2 comments · Fixed by brave/brave-core#23731
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@StephenHeaps
Copy link

StephenHeaps commented Feb 28, 2024 •
edited
Loading

Description

Cross-chain swaps are supported by LiFi (added to brave-core in #36335) but currently are disabled and not used in front-end. We'll need to update front-end for handling LiFiQuote model for desktop/android WebUI and iOS.

We should handle the swap quotes disclaimers change(s) in this issue as well. Slack Ref: https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1708974083632369
@StephenHeaps StephenHeaps added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/swap labels Feb 28, 2024
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Mar 1, 2024
@onyb onyb mentioned this issue May 17, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Jun 12, 2024
@brave-builds brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Jun 12, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 12, 2024
@StephenHeaps StephenHeaps removed the OS/iOS Fixes related to iOS browser functionality label Jun 14, 2024
@srirambv
Copy link
Contributor

srirambv commented Aug 9, 2024

Verification passed on

Brave 1.69.138 Chromium: 127.0.6533.100 (Official Build) beta (64-bit)
Revision 2569cce791e23282c250db59de277f2e81c33d9b
OS Windows 11 Version 23H2 (Build 22631.3880)
image image image

@srirambv srirambv mentioned this issue Aug 19, 2024
Open
6 tasks
@srirambv
Copy link
Contributor

Removing OS/Android label as Swaps is broken on Android and a follow up issuehttps://github.com//issues/40525 is logged.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Aug 19, 2024
@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): use LiFi provider for EVM swaps brave/brave-core
4 participants
@onyb @StephenHeaps @srirambv @brave-builds