Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] Panel crashes when attempting to lookup EIP1159 estimates for non EVM or FIL transactions #38970

Closed
1 of 6 tasks
josheleonard opened this issue Jun 11, 2024 · 1 comment · Fixed by brave/brave-core#24134
Closed
1 of 6 tasks

[Wallet] Panel crashes when attempting to lookup EIP1159 estimates for non EVM or FIL transactions #38970

josheleonard opened this issue Jun 11, 2024 · 1 comment · Fixed by brave/brave-core#24134
Assignees
@josheleonard
Labels
bug crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@josheleonard
Copy link

josheleonard commented Jun 11, 2024 •
edited
Loading

Description

We should not attempt to lookup EIP1159 gas feee estimates for transactions that are not EVM or FVM types.

Steps to reproduce

  1. Submit a Solana transaction from the "send" screen

Actual result

Panel crashes

Expected result

Panel should not crash

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.0 Chromium: 126.0.6478.40 (Developer Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@josheleonard josheleonard self-assigned this Jun 11, 2024
@josheleonard josheleonard moved this to In Progress in Web3 Jun 11, 2024
@josheleonard josheleonard mentioned this issue Jun 11, 2024
Merged
24 tasks
@josheleonard josheleonard moved this from In Progress to In Review in Web3 Jun 11, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 11, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jun 11, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.69.124 Chromium: 127.0.6533.73 (Official Build) beta (64-bit)
Revision dbc9035349f74e493f3293d93f4cbf35c597dfec
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from brave/brave-core#24134
  • Verified no browser crash when submitting a send transaction for ETH/SOL/BTC/ZEC/EVM Tokens
38970.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
bug crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): do not crash during fee estimate lookup for invalid coins brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds