Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out Choose Quote Provider for Bridge and Swap #39472

Closed
Douglashdaniel opened this issue Jun 28, 2024 · 1 comment · Fixed by brave/brave-core#24444
Closed

Build out Choose Quote Provider for Bridge and Swap #39472

Douglashdaniel opened this issue Jun 28, 2024 · 1 comment · Fixed by brave/brave-core#24444
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@Douglashdaniel
Copy link

Platforms

Linux, macOS, Windows

Description

We need to build out the Choose quote provider feature to allow user to select which Provider they want to use for a Swap or Bridge transaction.

Should replace the Settings button on the Swap and Bridge screen

Options should be

  • Auto (Will choose the best Quote Provider depending on the trade for the user.)
  • Li.Fi
  • 0x
  • Jupiter

Screenshot 9

Screenshot 8
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature-request feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 28, 2024
@Douglashdaniel Douglashdaniel self-assigned this Jun 28, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jun 28, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Jul 1, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jul 1, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jul 3, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 3, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.69.147 Chromium: 128.0.6613.40 (Official Build) (64-bit)
Revision d29b1747d0f906239936b0d94c40889920ebf2c0
OS Windows 11 Version 23H2 (Build 22631.4037)
  • Verified steps from brave/brave-core#24444
  • Verified clicking on the Brave icon in Swap/Bridge brings up the quote provider list
  • Verified on Swap, selecting ETH token as Swap from, Jupiter is disabled in quote provider list
  • Verified on Swap, selecting SOL token as Swap from, 0x is disabled in quote provider list
  • Verified selecting ETH token for Swap and selecting 0x as provider, changing ETH to SOL shows quote provider error message
  • Verified on Bridge, 0x and Jupiter are disabled in quote provider list
39472.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Choose Quote Provider brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds