Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tips flow #3953

Closed
NejcZdovc opened this issue Apr 1, 2019 · 1 comment · Fixed by brave/brave-core#2140
Closed

Refactor tips flow #3953

NejcZdovc opened this issue Apr 1, 2019 · 1 comment · Fixed by brave/brave-core#2140

Comments

@NejcZdovc
Copy link
Contributor

We need to move getters for tip list into ledger lib. Currently get tips is not wired though bat-native-ledger.

  1. Rename brave_rewards.updateTipsList to brave_rewards.getOneTimeTips
  2. Rename brave_rewards.updateRecurringDonationsList to brave_rewards.getRecurringTips
  3. Rename GetRecurringDonations to GetRecurringTips
  4. Wire GetRecurringTips through bat-native-ledger
  5. Rename UpdateTipsList to GetOneTimeTips and merge it with TipsUpdated function
  6. Wire GetOneTimeTips through bat-native-ledger
@LaurenWags
Copy link
Member

LaurenWags commented May 20, 2019

Verified passed with

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified test plan from Refactors tip flows brave-core#2140 with regular sites, youtube channels, and twitch channels. Verified with both auto contribute enabled and auto contribute disabled.

Verification passed on

Brave 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Verified test plan from brave/brave-core#2140

Verification passed on

Brave 0.65.111 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment