Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Update foregroundServiceType for VPN #40571

Closed
deeppandya opened this issue Aug 21, 2024 · 1 comment · Fixed by brave/brave-core#25244
Closed

[Android] Update foregroundServiceType for VPN #40571

deeppandya opened this issue Aug 21, 2024 · 1 comment · Fixed by brave/brave-core#25244
Assignees
@deeppandya
Labels
dev-concern feature/vpn OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Milestone
1.71.x - Release

Comments

@deeppandya
Copy link

deeppandya commented Aug 21, 2024 •
edited
Loading

Description

We have a new change coming with Android 15 related to foreground services https://developer.android.com/about/versions/15/behavior-changes-15#datasync-timeout.
We use it for VPN, the main change is that Android OS won't allow to run it for more than 6 hours in 24 hours (unless the user interacts with the app, resetting the timer).

Solution : We can use https://developer.android.com/about/versions/14/changes/fgs-types-required#system-exempted as it's ideal for VPN apps.
@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Aug 21, 2024
@deeppandya deeppandya self-assigned this Aug 21, 2024
@deeppandya deeppandya mentioned this issue Aug 21, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Sep 4, 2024
This was referenced Sep 4, 2024
Closed
Closed
@kjozwiak
Copy link
Member

Labelling as QA/No as discussed with @deeppandya. The above was reverted via brave/brave-core#25456. The whole VPN feature including the new Server/City selection will be verified alongside #36277 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
dev-concern feature/vpn OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

Update foregroundServiceType to systemExempted for VPN brave/brave-core
3 participants
@kjozwiak @deeppandya @brave-builds