Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Chromium 129.0.6668.42 iOS build fix after it's fixed upstream #41014

Open
mkarolin opened this issue Sep 11, 2024 · 0 comments
Open

Remove Chromium 129.0.6668.42 iOS build fix after it's fixed upstream #41014

mkarolin opened this issue Sep 11, 2024 · 0 comments
Assignees
@emerick @mkarolin
Labels
Chromium/Followup Followup work logged during Chromium rebase dev-concern OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

Description

brave/brave-core@97aab4f is not the right fix for the issue. It just takes advantage of our iOS implementation including content/public/common/url_constants.h into //brave/extensions:common target.

Once upstream fixes the headers inclusions and deps (https://chromium-review.googlesource.com/c/chromium/src/+/5814284/7/components/omnibox/browser/verbatim_match.cc#15), we should remove our "fix".
@mkarolin mkarolin added QA/No dev-concern release-notes/exclude OS/iOS Fixes related to iOS browser functionality Chromium/Followup Followup work logged during Chromium rebase labels Sep 11, 2024
@mkarolin mkarolin mentioned this issue Sep 17, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/Followup Followup work logged during Chromium rebase dev-concern OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emerick @mkarolin