Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Follow up to #40507: Add NTP media type p3a metrics #41026

Closed
btlechowski opened this issue Sep 12, 2024 · 4 comments · Fixed by brave/brave-core#25558
Closed

[ads] Follow up to #40507: Add NTP media type p3a metrics #41026

btlechowski opened this issue Sep 12, 2024 · 4 comments · Fixed by brave/brave-core#25558
Assignees
Labels
feature/ads features/P3A OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude

Comments

@btlechowski
Copy link

btlechowski commented Sep 12, 2024

Description

Follow up to #40507. When NTT is disabled through brave://rewards, p3a Brave.NTP.SponsoredMediaType is not changed.

Note: changing Brave.NTP.SponsoredMediaType through NTP works as expected

Steps to reproduce

  1. Enable rewards
  2. Open brave://rewards
  3. Turn off NTT
  4. Open brave://local-host and search for SponsoredMediaType

Actual result

Brave.NTP.SponsoredMediaType = 1

image

Expected result

Brave.NTP.SponsoredMediaType = 0

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.70.109 Chromium: 128.0.6613.138 (Official Build) beta (64-bit)
Revision fec4422ae56f4d9680c71a3c1de60b9a8e5ef32f
OS Linux

cc @tmancey @aseren @iambrianfung

@btlechowski
Copy link
Author

Reproduced on Android: Brave v1.70.114 on Lenovo TB-8506FS (Android 11.0)

image image

@LaurenWags
Copy link
Member

Requires 1.71.103 or higher for verification 👍🏻

@btlechowski
Copy link
Author

Verified on

Brave 1.71.105 Chromium: 129.0.6668.89 (Official Build) beta (64-bit)
Revision f69ba167992437799f1dbcce81e90ba501a3d63e
OS Linux

Verified test plan from brave/brave-core#25558

Test case 1

Clean install

image image

Disabled Background images

image image

Enabled Background images

image image

Test case 2

Clean install

image image

Disabled NTT

image image

Enabled NTT

image image

Test case 3

After joining rewards:

image image image

Disabled NTT from brave://rewards

image image image

Enabled NTT from brave://rewards

image image image

@btlechowski
Copy link
Author

Verification passed on Brave v1.71.114 on Lenovo TB-8506FS (Android 11.0)

Verified test plan from brave/brave-core#25558

Test case 1

Clean install

Image Image

Disabled Background images

Image Image

Enabled Background images

Image Image

Test case 2

Disabled NTT

Image Image

Enabled NTT

Image Image

Test case 3

After joining rewards:

Image|Image
--|--|--

Disabled NTT from brave://rewards
Image|Image
--|--|--

Enabled NTT from brave://rewards

Image|Image
--|--|--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ads features/P3A OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants