Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads aren’t saving, files disappear after download #41073

Closed
2 of 5 tasks
Saoiray opened this issue Sep 14, 2024 · 16 comments · Fixed by brave/brave-core#25651
Closed
2 of 5 tasks

Downloads aren’t saving, files disappear after download #41073

Saoiray opened this issue Sep 14, 2024 · 16 comments · Fixed by brave/brave-core#25651

Comments

@Saoiray
Copy link

Saoiray commented Sep 14, 2024

Description

When downloading anything and trying to save to Files, it never appears. This issue appears to only exist with Brave and does not happen in Chrome or Safari.

Steps to reproduce

  1. Navigate to a site with a downloadable file
  2. Download the file
  3. Go to Downloads in Brave or navigate to Files on iOS

Actual result

The downloaded file doesn't exist. Downloads is empty

Expected result

File should be downloaded and available for use.

Reproduces how often

Easily reproduced

Brave version

1.69.1

Device/iOS version

iOS 17.6.1
iOS 17.4.1

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

Issue reported by users at https://community.brave.com/t/downloaded-videos-on-ios/568738/

Then was able to replicate myself as well.

SIDE NOTE
I could swear we used to have the ability to choose download destinations within Brave on iOS but I don't see that anywhere now. Did this change or am I thinking more of Android?

@Saoiray Saoiray added the OS/iOS Fixes related to iOS browser functionality label Sep 14, 2024
@GROSU1
Copy link

GROSU1 commented Sep 16, 2024

Happened after latest release on Friday 13th, previously worked without issues. Version build 171 of 1.69.1.
Just tested on 18.0 today with the same issue. Was thinking some change might have been for the new major iOS release but it doesn't seem like it.

@bompao108
Copy link

Got the same problem. Can't even download anything although the download section is finished tho

@roafhtun
Copy link

same problem here, goes to look into Files app on iOS nothing is downloaded there.

@Brave-Matt
Copy link

@Brave-Matt
Copy link

@lukemulks
Copy link

+1 from user via DM on X
Screenshot_20240917_183634_X

@teanea
Copy link

teanea commented Sep 19, 2024

me too

@KMatuszak
Copy link

Same issue on iPadOS 18.0

@bompao108
Copy link

issue

This download issue is terrible cuz I can't download anything via Brave
I need to have another browser in my iPhone

@bompao108
Copy link

@kylehickinson
no bro it ain't fix nothing yet
I just downloaded Brave back
Tested Youtube, Tiktok, ... Still aint got any videos after the download finishes

@bompao108
Copy link

@kylehickinson proof :
IMG_0465
IMG_0466
IMG_0467

@kylehickinson
Copy link
Collaborator

@bompao108 this fix hasn't shipped to any public builds yet. Keep an eye out for 1.69.2 in the next few days

@bompao108
Copy link

@bompao108 this fix hasn't shipped to any public builds yet. Keep an eye out for 1.69.2 in the next few days

Thanks. I need it

@kjozwiak
Copy link
Member

The above requires 1.69.172 or higher for 1.69.x verification. We'll be starting RC builds shorty and hoping to get them approved by Apple sometime today/tomorrow. Once approved, we'll start pushing the fix out via 1.69.172. Unless we find other issues related to Downloads & Passbook while verifying the RC builds.

@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 18 using the following build(s):

Brave | 1.69.172 Chromium: 128.0.6613.138 (Official Build) stable (64-bit) 
--- | ---
Revision | 6da7ca9e1ca7...
OS | iOS

Using similar STR/Cases outlined via brave/brave-core#25651 (comment), went through the following:

Passbook verification(s):

Example Example Example Example Example
IMG_0564 IMG_0565 IMG_0567 IMG_0566 IMG_0568
Example Example Example Example
IMG_0569 IMG_0571 IMG_0570 IMG_0572

PDF download verification(s):

Example Example Example Example
IMG_0580 IMG_0581 IMG_0582 IMG_0583

Image download verification(s):

Example Example Example Example
IMG_0575 IMG_0576 IMG_0577 IMG_0578

Instagram download verification (case provided by Community):

Example Example Example Example Example Example
IMG_0584 IMG_0586 IMG_0588 IMG_0589 IMG_0590 IMG_0591

@Uni-verse
Copy link
Contributor

Verified on iPad (7th Gen) running iPadOS 17.5.1 using version 1.69.2 (172)

Case: snapinsta.app - PASSED

  • Went through the test steps below and ensured that file is downloaded successfully and shown in Downloads folder.
example example example
IMG_1625 IMG_1626 IMG_1627

Case: PDF download - PASSED

  • Ensured that downloading PDF files is working using Save to Files in share menu
example example example
IMG_1628 IMG_1629 IMG_1630

Case: Saving Image to Photos - PASSED

example example example
IMG_1634 IMG_1635 IMG_1637

Case: Add to Wallet - DEFERRED

example example
IMG_1638 IMG_1639

*Note: iPad (7th Gen) does not support Passbook.

Case: Direct Download (unsplash) - PASSED

example example example
IMG_1631 IMG_1632 IMG_1633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment