Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some buttons still have orange ring/outline on dark theme #41125

Closed
2 of 6 tasks
LaurenWags opened this issue Sep 18, 2024 · 2 comments · Fixed by brave/brave-core#25635
Closed
2 of 6 tasks

some buttons still have orange ring/outline on dark theme #41125

LaurenWags opened this issue Sep 18, 2024 · 2 comments · Fixed by brave/brave-core#25635
Assignees
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 18, 2024

Description

When using dark theme, some buttons still have an orange ring/outline. This orange ring/outline is not there in light theme.

Per discussion via https://bravesoftware.slack.com/archives/C01EVLWS8R5/p1726641052480589?thread_ts=1726626360.304599&cid=C01EVLWS8R5 there shouldn't be any orange.

Also found by @AlanBreck as well 👍🏻

Steps to reproduce

  1. Be sure you are using dark theme (brave://settings/appearance > Brave Colors > Dark)
  2. Open brave.com in a tab
  3. Open a new tab
  4. Type "brave." in the URL bar
  5. In the drop down you will see an entry for brave.com with a button that says "Switch to this tab", this button has an orange ring/outline
  6. In the URL bar erase what you've written and type ":br"
  7. In the drop down you will see an entry that has a "Search Brave" button, this button has an orange ring/outline
  8. If you repeat the above with light theme, there's no orange

(note, my step 6 and 7 have different button text in the screenshots below, but the premise is the same)

Actual result

Dark has orange, light does not

Dark Light
1 72 6a 1 72 a-lt
1 72 6b 1 72 b-lt

Expected result

No orange in dark theme

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.72.6 Chromium: 129.0.6668.42 (Official Build) nightly (x86_64)
Revision 2071656859878e424523b78457dc7a21d7f8d01c
OS macOS Version 14.6.1 (Build 23G93)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Beta (1.71.x) and Nightly (1.72.x) have this issue, RC (1.70.x) does not:

1.70.114 Dark 1.70.114 Light
1 70 115 1 70 115-lt
@LaurenWags
Copy link
Member Author

cc @rebron

@fallaciousreasoning
Copy link

@aguscruiz I think we should fix this by making the secondary color look less jarring next to the primary color - until them, I'm just going to make the TonalOutline the primary scheme, which is similar to what we do in Nala

However, I don't really see the point in our secondary colors if we can't use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants