Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insufficient funds message immediately after auto contribution #4115

Closed
SergeyZhukovsky opened this issue Apr 16, 2019 · 3 comments · Fixed by brave/brave-core#2228
Closed

Insufficient funds message immediately after auto contribution #4115

SergeyZhukovsky opened this issue Apr 16, 2019 · 3 comments · Fixed by brave/brave-core#2228
Assignees
@gdregalo
Labels
feature/rewards QA/No release-notes/exclude
Milestone
0.65.x - Release ...

Comments

@SergeyZhukovsky
Copy link
Member

The original issue is described in Android repo https://github.com/brave/browser-android-tabs/issues/1465. Not sure is it appeared on desktop, but it is likely.
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Apr 16, 2019
Merged
20 tasks
@NejcZdovc NejcZdovc added this to the 0.65.x - Nightly milestone Apr 17, 2019
@NejcZdovc NejcZdovc mentioned this issue Apr 19, 2019
Closed
This was referenced May 10, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

Is a regression test of contribution sufficient or are there additional scenarios QA should cover? If no manual QA is needed, can we mark as QA/No?

@SergeyZhukovsky
Copy link
Member Author

Hey @LaurenWags I believe we checked that on Android repo, not sure was it a problem ever on desktop. So marking it as QA/No.

@LaurenWags
Copy link
Member

thanks @SergeyZhukovsky 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdregalo gdregalo

Labels
feature/rewards QA/No release-notes/exclude
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fixed WALLET_PROPERTIES_ST serialization brave/brave-core
4 participants
@NejcZdovc @SergeyZhukovsky @LaurenWags @gdregalo