Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/tools/licenses/licenses.py not covering all cases until merged to master #41157

Closed
cdesouza-chromium opened this issue Sep 20, 2024 · 1 comment · Fixed by brave/brave-core#25673

Comments

@cdesouza-chromium
Copy link
Contributor

cdesouza-chromium commented Sep 20, 2024

Description

Recently a PR updating rust dependencies got merged and immediately after the CI running master builds [2] started failing on the license step. It is not clear why this validation was never triggered either on the local level, or on the CIs for the PR itself.

This should be fixed so we don't get a broken master that late, where fixing things become a bit uncertain.

It seems to be the case that the crates added to brave/third_party/rust/chromium_crates_io/Cargo.toml in this particular PR were supposed to be listed in brave/script/brave_license_helper.py as well, as part of the prune paths.

[1] brave/brave-core#25666
[2] https://ci.brave.com/job/brave-browser-build-linux-x64/7166/execution/node/172/log/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants