Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline tip panel contains Make this monthly checkbox #4556

Closed
LaurenWags opened this issue May 23, 2019 · 2 comments
Closed

inline tip panel contains Make this monthly checkbox #4556

LaurenWags opened this issue May 23, 2019 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

When accessed from an inline twitter tip, the tip panel has the 'Make this monthly' checkbox, but spec screenshots do not have this option for inline tips.

Steps to Reproduce

  1. Install build equipped with twitter tips
  2. Enable Rewards
  3. Navigate to a twitter site, click on Tip button for a tweet.

Actual result:

Twitter tip banner is displayed with Make this monthly option.
Screen Shot 2019-05-23 at 12 54 36 PM

Expected result:

Twitter tip banner is displayed without Make this monthly option.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @mandar-brave @alexwykoff @jenn-rhim

@NejcZdovc
Copy link
Contributor

closing as we want to have monthly on inline tips as well

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone May 27, 2019
@kjozwiak kjozwiak removed this from the Dupe / Invalid / Not actionable milestone May 28, 2019
@LaurenWags
Copy link
Member Author

@mandar-brave @jenn-rhim @alexwykoff please make sure the spec is updated accordingly.

cc @kjozwiak

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants