Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uBO's injections to address some webcompat / perf issues #4564

Closed
pes10k opened this issue May 23, 2019 · 1 comment · Fixed by brave/adblock-rust#50
Closed

Use uBO's injections to address some webcompat / perf issues #4564

pes10k opened this issue May 23, 2019 · 1 comment · Fixed by brave/adblock-rust#50
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
Closed / Dupe / I...

Comments

@pes10k
Copy link
Contributor

pes10k commented May 23, 2019

uBO has a large number of things it injects, when it blocks certain network requests, to avoid breaking pages / hitting slow paths (ex, issue #4402 )

It would be good to pull in all of these injection rules, along the same lines as we do for GoogleTagManager

Full list of injected resources
https://github.com/uBlockOrigin/uAssets/blob/master/filters/resources.txt
@pes10k pes10k added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label May 23, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 31, 2019
@antonok-edm antonok-edm mentioned this issue Oct 11, 2019
Merged
@pes10k
Copy link
Contributor Author

pes10k commented Oct 21, 2019

another example : https://adblockplus.org/

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

Successfully merging a pull request may close this issue.

Migrate to web_accessible_resources and scriptlets.js brave/adblock-rust
3 participants
@pes10k @bbondy @rebron