Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odd tip banner display when tweet has a lot of returns #4566

Closed
LaurenWags opened this issue May 23, 2019 · 4 comments
Closed

odd tip banner display when tweet has a lot of returns #4566

LaurenWags opened this issue May 23, 2019 · 4 comments
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. QA/Test-Plan-Specified QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

If you go to tip a tweet with a lot of returns in it, the tip banner gets pretty big, but does eventually get a scroll bar. However, the tip amounts are at the bottom of the banner, so it looks a little odd.

Steps to Reproduce

  1. Locate a tweet with a lot of returns in it.
  2. Tip that tweet.

Actual result:

Tipping banner gets pretty large and looks odd - tip amounts are at the bottom of the banner so you have to scroll for them.
Screen Shot 2019-05-23 at 3 34 42 PM
Screen Shot 2019-05-23 at 3 34 49 PM

Expected result:

Maybe have the scroll limited to the area where the tweet is - if not, have the tip amounts always display, no matter where you are in scrolling to read the tweet.

Reproduces how often:

easy

Brave version (brave://version info)

Brave 0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@NejcZdovc NejcZdovc added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label May 27, 2019
@NejcZdovc
Copy link
Contributor

I would personally limit tweet box so that after some point we would just cut it.

cc @jenn-rhim @alexwykoff

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 22, 2021

@LaurenWags Is this still relevant with the new tipping panel in current release ver? Above is for old tipping panel design. Thanks.

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 27, 2021

@Miyayes seems better with new panel design, a little stretched but that feels normal. wdyt?

This tweet https://twitter.com/PuckPodcast/status/1418636977876860929 doesn't have as many returns, but you can see that the new panel design truncates whereas the old one did not.

Example Example
Screen Shot 2021-10-27 at 10 02 44 AM Screen Shot 2021-10-27 at 10 02 54 AM

Used

Brave | 1.32.81 Chromium: 95.0.4638.54 (Official Build) beta (x86_64)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | macOS Version 11.6 (Build 20G165)

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 27, 2021

Thanks for testing! I think that looks fine, so will close this out :) If we notice anything super grotesque in the future, we can open another issue.

@Miyayes Miyayes closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

3 participants