Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards notification to try Ads is incorrectly showing - Follow up to 4339 #4627

Closed
LaurenWags opened this issue May 28, 2019 · 3 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented May 28, 2019

Description

Originally reported as part of #4339

In some cases Ads were being turned off on upgrade- when this happened users were given a Rewards notification (visible via BAT logo) to enable Ads.

After #4339 was fixed (Ads are not disabled when updating from 0.64.26 to 0.67.63 on Nightly), but I still get a notification on BAT logo to try Ads in this upgrade scenario.

Steps to Reproduce

  1. Install 0.64.26 on Nightly.
  2. Enable Rewards
  3. View an Ad. If brave://rewards page is open, close it.
  4. Update to 0.67.63.

Actual result:

There is a notification on your BAT logo telling you that Brave Ads have arrived. If you go to brave://rewards, you will see that Ads are on and the notification goes away (without interaction from you).

4339-test-nightly064x

Expected result:

No notification on BAT logo to try Ads as Ads should still be enabled.

Reproduces how often:

easily

Brave version (brave://version info)

0.64.26 updated to 0.67.63

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? unsure (4339 has not been uplifted to this channel yet)
  • Can you reproduce this issue with the dev channel? unsure (4339 has not been uplifted to this channel yet)
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @jsecretan @ryanml

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 29, 2019

The issue is Reproducible - Upgraded 0.64.10 to 0.67.66 - There is Turn On Ads notification after upgrade, even though Ads switch is enabled in brave://rewards

Brave 0.67.66 Chromium: 75.0.3770.38 (Official Build) nightly (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)

@jsecretan jsecretan added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 12, 2019
@tmancey
Copy link
Contributor

tmancey commented Jul 10, 2019

@LaurenWags This ticket will be superseded and subsequently fixed by #4383, are you happy for us to close this ticket please?

@LaurenWags
Copy link
Member Author

sure @tmancey - if we're doing additional notifications per #4383 then I think this can be closed.

@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed QA/Test-Plan-Specified QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 11, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Mar 6, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants