Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly on Win10 doesn't have Same as Windows option in Brave colors setting #4760

Closed
simonhong opened this issue Jun 7, 2019 · 3 comments · Fixed by brave/brave-core#2892
Closed

Nightly on Win10 doesn't have Same as Windows option in Brave colors setting #4760

simonhong opened this issue Jun 7, 2019 · 3 comments · Fixed by brave/brave-core#2892
Assignees
@simonhong
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
0.69.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Jun 7, 2019 •
edited
Loading

This is regression of recent disabling of field trial.

Dark mode on Windows is disabled by default in C75 and we enabled it by field trial implicitly.
See kDarkMode in ui_base_features.cc is disabled by default in C75.
After disabling field trial, it is disabled again. So, Same as Windows option is hidden on Nightly.
Same as Windows option is only visible when kDarkMode feature is enabled.

Upstream enabled dark mode by default in C76. (https://chromium-review.googlesource.com/c/chromium/src/+/1597930)

Should we leave it until we rebase on C76 or cherry-pick in advance?

cc: @bbondy @bsclifton @mkarolin @rebron
@simonhong simonhong self-assigned this Jun 12, 2019
@simonhong simonhong added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Jun 19, 2019
@simonhong simonhong added this to the 0.68.x - Nightly milestone Jun 19, 2019
@simonhong
Copy link
Member Author

This will be resolved when we finish C76 rebasing (brave/brave-core@6ac4175)

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 21, 2019
@rebron
Copy link
Collaborator

rebron commented Jul 11, 2019 •
edited
Loading

Closing. Fixed in Version 0.69.54 Chromium: 76.0.3809.62 (Official Build) nightly (64-bit)

@rebron rebron closed this as completed Jul 11, 2019
@rebron rebron modified the milestones: 0.68.x - Dev, 0.69.x - Nightly Jul 11, 2019
@mkarolin mkarolin mentioned this issue Jul 11, 2019
Merged
32 tasks
@srirambv srirambv mentioned this issue Aug 22, 2019
Closed
@GeetaSarvadnya
Copy link

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the description mentioned in the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 75.0.3770.100 to Chromium 76.0.3809.62 brave/brave-core
4 participants
@rebron @simonhong @LaurenWags @GeetaSarvadnya