Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insecure script modal links to google support page #517

Closed
srirambv opened this issue Jul 10, 2018 · 1 comment · Fixed by brave/brave-core#478
Closed

Insecure script modal links to google support page #517

srirambv opened this issue Jul 10, 2018 · 1 comment · Fixed by brave/brave-core#478
Assignees
@yrliou
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Insecure script modal links to google support page

Steps to Reproduce

  1. Visit https://mixed-script.badssl.com/
  2. Click insecure script in URL
  3. Click on Learn More open google support page

Actual result:

image
@srirambv srirambv added this to the Releasable builds milestone Jul 10, 2018
@yrliou yrliou assigned yrliou and unassigned yrliou Sep 1, 2018
@yrliou yrliou mentioned this issue Sep 19, 2018
Merged
11 tasks
@btlechowski
Copy link

btlechowski commented Sep 24, 2018 •
edited by LaurenWags
Loading

Verification passes on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Opens https://community.brave.com/

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Opens https://community.brave.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Replace learn more links in content setting bubbles brave/brave-core
4 participants
@yrliou @srirambv @LaurenWags @btlechowski