Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confirm button from changing theme option in onboarding #5509

Closed
srirambv opened this issue Aug 2, 2019 · 5 comments · Fixed by brave/brave-core#3088
Closed

Remove confirm button from changing theme option in onboarding #5509

srirambv opened this issue Aug 2, 2019 · 5 comments · Fixed by brave/brave-core#3088

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 2, 2019

Description

Remove confirm button from changing theme option in onboarding

Actual result:

image

Expected result:

No confirm button required as the drop-down makes the visual change instantly

cc: @simonhong @rebron @rossmoody

@kjozwiak
Copy link
Member

kjozwiak commented Aug 2, 2019

Also mentioned via #1548 (comment) where we had a discussion regarding removing both of the Confirm buttons for both Search and Themes.

Agreed that the confirm button seems a but redundant for theme selection. However, @rossmoody made some good points via #1548 (comment). However, might be more applicable to the Confirm button for Search.

@srirambv
Copy link
Contributor Author

srirambv commented Aug 2, 2019

I feel instead of having the confirm button, we can just add a text label that says New search engine set if user changes the default from dropdown. The button placement looks odd to me. Adding the text makes visual confirmation as well and avoids awkward button placement as well. Just a thought but will leave decision upto the design team

@kjozwiak
Copy link
Member

kjozwiak commented Aug 2, 2019

CCing @rossmoody to update the above with a possible new implementation discussed on Slack.

@rossmoody
Copy link
Contributor

I think the direction of this one can stay as-is. Removing the confirm button for this panel is non-detrimental and users can use the next button.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 23, 2019

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-26 at 1 37 08 PM

Screen Shot 2019-09-26 at 1 36 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants