-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove confirm button from changing theme option in onboarding #5509
Comments
Also mentioned via #1548 (comment) where we had a discussion regarding removing both of the Agreed that the confirm button seems a but redundant for theme selection. However, @rossmoody made some good points via #1548 (comment). However, might be more applicable to the |
I feel instead of having the confirm button, we can just add a text label that says |
CCing @rossmoody to update the above with a possible new implementation discussed on Slack. |
I think the direction of this one can stay as-is. Removing the confirm button for this panel is non-detrimental and users can use the next button. |
Verification passed on
Verification passed on
Verification PASSED on
|
Description
Remove confirm button from changing theme option in onboarding
Actual result:
Expected result:
No confirm button required as the drop-down makes the visual change instantly
cc: @simonhong @rebron @rossmoody
The text was updated successfully, but these errors were encountered: