Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip banner text alignment is messed on default window size #5870

Closed
srirambv opened this issue Sep 3, 2019 · 1 comment
Closed

Tip banner text alignment is messed on default window size #5870

srirambv opened this issue Sep 3, 2019 · 1 comment
Labels
bug feature/rewards priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 3, 2019

Description

Tip banner text alignment is messed on default window size

Steps to Reproduce

  1. Clean profile on 0.69.121
  2. Do not change the default browser window size (important step)
    3.Enable Rewards
  3. Visit reddit.com/r/basicattentiontoken/
  4. Tip on different threads, see horrible text alignment

Actual result:

🤢
Screenshot from 2019-09-03 12-38-48
Screenshot from 2019-09-03 12-39-00

Expected result:

Properly align the tip banner based on the size of browser window

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? most likely yes
  • Can you reproduce this issue with the nightly channel? most definitely yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

May be side effect of #2015
cc: @NejcZdovc @brave/rewards @brave/legacy_qa

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 3, 2022

Closing as stale since this is old tipping banner design.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Development

No branches or pull requests

3 participants