Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask should be removed from successful message on completing the challenge #6100

Closed
srirambv opened this issue Sep 20, 2019 · 3 comments
Closed

Comments

@srirambv
Copy link
Contributor

Description

Metamask should be removed from the successful message on completing the challenge

Steps to Reproduce

  1. Create a new browser profile
  2. Open brave://wallet and click on Ledger/Trezor
  3. Create an account
  4. Copy the secret code
  5. Finish selecting the code words to complete the challenge
  6. Upon completion, congratulations message is shown that says Metamask
  7. Learn more at the end of the message links to Metamask page

Actual result:

image

Expected result:

No Metamask branding on wallet pages

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.71.75 Chromium: 77.0.3865.75 (Official Build) dev (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @Brave-Matt @atsyed87 to create Brave page similar to https://metamask.zendesk.com/hc/en-us/articles/360015489591-Basic-Safety-Tips that needs to be linked in the message after rebranding
cc: @bbondy @tomlowenthal

@ryanml
Copy link
Contributor

ryanml commented Sep 20, 2019

This is fixed client side as of: brave/ethereum-remote-client@b2d03a4

This will be reflected in the browser when we do next version bump cc: @srirambv

Screen Shot 2019-09-21 at 1 51 50 PM

@ryanml
Copy link
Contributor

ryanml commented Oct 5, 2019

This is fixed in latest release

@ryanml ryanml closed this as completed Oct 5, 2019
@kjozwiak kjozwiak added this to the 0.69.x - Release milestone Oct 7, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Used Crypto Wallets - Version: 1.0.9 and verified the following:

Screen Shot 2019-10-07 at 1 24 23 AM

Verification passed on

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR mentioned in the issue

image

Verification passed on

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux
  • Verified successful message contains brave on component 1.0.9
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants