Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About wallet page has links to MM #6101

Closed
srirambv opened this issue Sep 20, 2019 · 3 comments
Closed

About wallet page has links to MM #6101

srirambv opened this issue Sep 20, 2019 · 3 comments

Comments

@srirambv
Copy link
Contributor

Description

About wallet, page has links to MM

Steps to Reproduce

  1. Enable crypto wallet
  2. Open profile and go to info
  3. All link to MM pages

Actual result:

Privacy Policy -> https://metamask.io/privacy.html
Attributions -> https://metamask.io/attributions.html
Visit our Support Center -> https://support.metamask.io/
Visit our web site -> https://metamask.io/
Email us! -> mailto:help@metamask.io?subject=Feedback

Expected result:

Have Brave specific links

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.71.75 Chromium: 77.0.3865.75 (Official Build) dev (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @Brave-Matt @atsyed87 for help center pages
cc: @tomlowenthal @bbondy

@ryanml ryanml self-assigned this Sep 21, 2019
@ryanml
Copy link
Contributor

ryanml commented Sep 21, 2019

This is awaiting deployment via: brave/ethereum-remote-client#57 && brave/ethereum-remote-client#56

The About settings tab is removed, as well as the Info & Help link which goes out to it. We can update with the proper links once we have full coverage cc: @srirambv

@bbondy
Copy link
Member

bbondy commented Oct 2, 2019

Should be fixed in the latest ethereum-remote-client extension update. Please try again @srirambv

@bbondy bbondy closed this as completed Oct 2, 2019
@bbondy bbondy added this to the 0.69.x - Release milestone Oct 2, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Oct 2, 2019

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux
  • Verified no About wallet section shown in Settings on component ver: 1.0.9

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1903 (Build 18362.30)
  • Verified no About wallet section shown in Settings on component ver: 1.0.9

Verification PASSED on macOS 10.14.6 x64 using the following builds:

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured that the About tab under Settings has been removed using Crypto Wallets - Version: 1.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment