-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDG URL is being updated on upgrade - follow up to 6187 #6469
Comments
Added to 0.70.x milestone and added |
@LaurenWags is this a dupe of #6424? Fixing this might be difficult. Will talk with @rebron |
Closing as The entries will remain there (untouched) if you either set as default engine or edit the keyword (ex: user interacts with it). I believe these types of changes are saved in |
Description
Follow up from https://github.com/brave/internal/issues/647#issuecomment-541900942 and #6187
DDG search engine entry is being updated to new URL for existing users in certain cases.
Steps to Reproduce
pre-req: use DE, AU, NZ, IRL
Actual result:
DDG entry shows new URL (DE):
![Screen Shot 2019-10-14 at 16 45 34](https://user-images.githubusercontent.com/28145373/66781735-13741c80-eea2-11e9-890a-c883be3312d9.png)
DDG entry shows new URL (AU, NZ, IRL):
![Screen Shot 2019-10-14 at 4 47 08 PM](https://user-images.githubusercontent.com/28145373/66781812-49190580-eea2-11e9-84bd-8337efa02bed.png)
Expected result:
DDG entry should retain previous URL even when it is not the default on upgrades:
![Screen Shot 2019-10-14 at 4 47 51 PM](https://user-images.githubusercontent.com/28145373/66781846-60f08980-eea2-11e9-92e0-1e4e3ba0b37a.png)
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @rebron @bsclifton @brave/legacy_qa
The text was updated successfully, but these errors were encountered: