Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto refresh page when selecting 'Always allow autoplay on..." setting #6700

Closed
rebron opened this issue Oct 31, 2019 · 1 comment · Fixed by brave/brave-core#3864
Closed

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 31, 2019

Description

When users have autoplay blocked, we'll show the autoplay icon. However, if selecting 'Always allow autoplay on ..." nothing happens. A user needs to manually refresh the page. We should automatically refresh the page after a user selects 'Always allow autoplay on...' setting and hits done.

Steps to Reproduce

  1. Go to https://www.tesla.com/model3 or a page you know will trigger autoplay
  2. Select autoplay icon.
  3. Notice that you'll need to manually refresh page in order for 'Always allow autoplay' setting to actually work.

Screen Shot 2019-10-31 at 4 37 50 PM

Expected result:

Autorefresh of page after selecting `Always allow autoplay on ...' and hitting done or enter.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 20, 2019

Verified passed with

Brave 1.2.5 Chromium: 78.0.3904.97 (Official Build) dev (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Verification passed on

Brave 1.2.6 Chromium: 78.0.3904.97 (Official Build) dev (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified STR from description

Verification passed on

Brave 1.2.10 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment