UK English sometimes Private/Private Window is not capitalized

[LaurenWags]

Description

While testing #2147 I noticed that the capitalization of Private Window isn't consistent across translations.

For example, here is English (US). Private/Private Window is capitalized as I would expect:
hamburger menu:

on the window:

from Brave menu (macOS):

right click:

Compared to English (UK), only 2 of the 4 items above are capitalized correctly - Hamburger menu and Brave menu (macOS):

On the window and right click, Private/Private Window is not capitalized as I would expect:

Steps to Reproduce

Use a language other than English (US).

1. Launch Brave with a clean profile.
2. View the following places:

• hamburger menu
• Private Window
• right click on a link to view context menu
• Brave menu (macOS/Linux)

3. See inconsistencies across capitalization.

Actual result:

English (AU) - is similar to English UK:

DE - a little different, sometimes Private isn't capitalized, but Window is

Expected result:

Consistency in capitalization for Private/Private Window

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[bsclifton]

cc: @petemill (I know you fixed the hamburger menu usage of this via brave/brave-core#3922)

[petemill]

🤦‍♂

[bsclifton]

Fixed in 0.71.x with brave/brave-core#3970 (other versions will get fixed when pulling translations for C79)

[LaurenWags]

To confirm, brave/brave-core#3970 will only fix English (UK) correct, no other languages?

[bsclifton]

@LaurenWags that is correct! 😄

[petemill]

@LaurenWags with regards to other languages, I learnt (when dealing with the translations for these strings, although it would apply to many other strings we have) that different languages do not do 'title case'. So, we'd need to take it on a case-by-case basis as to whether the translation for a specific language is was correctly translated to title-case when appropriate for that language.

I'll amend the title of this issue to make it clear that it only applies to UK English.

[LaurenWags]

That's fair. Mostly wanted to clarify so when @brave/legacy_qa goes to test this one, they don't bother with the other languages I had listed. We can do as you suggest and deal with them on a case by case basis and log issues appropriately as they come up. cc @kjozwiak @rebron

[LaurenWags]

Verified passed with

Brave	0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified STR from description
  hamburger menu

Private Window - logged #6890

right click on a link to view context menu - logged #6891

Brave menu (macOS/Linux)

Verification passed on

Brave	0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

en_GB is not capitalized at all on Linux

• Verified STR from description
  
  
  

Verification passed on

Brave	0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified STR from the description

• Encountered Private Window does not say 'Private' in UK English - follow up to 6872 #6890
  In English (UK) Private is not capitalized in Hamburger Menu and Context menu, it's same like Linux