Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ABP filter redirects as mock responses #6894

Closed
bbondy opened this issue Nov 12, 2019 · 0 comments · Fixed by brave/brave-core#3419
Closed

Add support for ABP filter redirects as mock responses #6894

bbondy opened this issue Nov 12, 2019 · 0 comments · Fixed by brave/brave-core#3419
Assignees
Labels
feature/shields/adblock Blocking ads & trackers with Shields QA/Yes

Comments

@bbondy
Copy link
Member

bbondy commented Nov 12, 2019

Description

This adds support for redirect option ABP filter syntax rules.
This gives us the ability to mock out URLs without doing C++ code changes.
It is expected that this will solve a lot of different webcompat issues.

Steps to Reproduce

  1. Go to https://winniethepooh.disney.com/
  2. Open DOM inspector
  3. Reload the page
  4. In the network pane filter for gpt.js

Actual result:

Has the normal content for that URL.

Expected result:

Should have uBlock related content.
Screen Shot 2019-11-11 at 9 53 08 AM
Screen Shot 2019-11-11 at 9 50 30 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant