Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dino Game has issues on dark mode #6958

Closed
erfgsthj opened this issue Nov 15, 2019 · 5 comments
Closed

Dino Game has issues on dark mode #6958

erfgsthj opened this issue Nov 15, 2019 · 5 comments
Assignees
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix repros-on-chrome

Comments

@erfgsthj
Copy link

Description

When the browser is in dark theme, the dino in the offline dino game does not display nighttime correctly, and the dino image has issues

Steps to Reproduce

  1. set theme to dark
  2. go to chrome://dino
  3. Issues occur when game turns to night, and when dino is ducking (down arrow key)

Actual result:

Expected result:

Reproduces how often:

Easily Reproduced

Brave version (brave://version info)

Revision | 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}

OS | macOS Version 10.15.1 (Build 19B88)

Version/Channel Information:

i don't know

  • Can you reproduce this issue with the current release?
    yes
  • Can you reproduce this issue with the beta channel?
    i don't know
  • Can you reproduce this issue with the dev channel?
    i don't know
  • Can you reproduce this issue with the nightly channel?
    i don't know

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    no
  • Does the issue resolve itself when disabling Brave Rewards?
    no
  • Is the issue reproducible on the latest version of Chrome?
    no

Miscellaneous Information:

Night comes at around 700 points
dino image issue is a blinking line behind the dino while ducking, and the black border around the dino at any time.

@bsclifton
Copy link
Member

bsclifton commented Nov 19, 2019

Reproduces in Chrome; verified issues

  1. Seems colors get swapped (ex: day mode is dark, night mode is light) when in dark mode

Screen Shot 2019-11-18 at 5 39 39 PM

  1. Artifacts around dino when ducking
    image

@kjozwiak
Copy link
Member

@bobrobot1 probably worth creating an issue under https://bugs.chromium.org/p/chromium/issues/. I tried searching for dina page, dino game, dino color, dino theme but couldn't find an issue.

@bsclifton
Copy link
Member

Reported officially here:
https://bugs.chromium.org/p/chromium/issues/detail?id=1026136

Thanks @bobrobot1

@bsclifton bsclifton self-assigned this Nov 19, 2019
@bsclifton bsclifton added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Nov 19, 2019
@bsclifton
Copy link
Member

@bsclifton
Copy link
Member

and awesome- my patch was accepted/merged 🎉
https://chromium.googlesource.com/chromium/src/+/9bf6154b3ac9ff3fcf789d6dd2078ef50d70b72b

I'll go ahead and close this out (will be coming in a future Chromium version). Thanks for the report

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix repros-on-chrome
Projects
None yet
Development

No branches or pull requests

4 participants