Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open brave ads from notification on Ubuntu 19.10 #6962

Closed
atharvan opened this issue Nov 16, 2019 · 11 comments
Closed

Unable to open brave ads from notification on Ubuntu 19.10 #6962

atharvan opened this issue Nov 16, 2019 · 11 comments

Comments

@atharvan
Copy link

atharvan commented Nov 16, 2019

Description

When clicking brave notification ads, the notification closes without opening the ad

Steps to Reproduce

  1. open brave
  2. brave ads showing as a push notification.
  3. Click the ad notification

Actual result:

  1. notifications closes without opening the ad

Expected result:

  1. it should open the Ads

Reproduces how often:

always

Brave version (brave://version info)

Brave 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel?Not tested
  • Can you reproduce this issue with the dev channel?Not tested
  • Can you reproduce this issue with the nightly channel?Not tested
@fmarier
Copy link
Member

fmarier commented Nov 19, 2019

I also noticed that problem using dunst as the notification manager. This is what's in my logs:

dunst[5266]: WARNING: Invoking action 'default' not supported. Notification already closed.

This has worked in the past, so something must have changed.

@bsclifton
Copy link
Member

Related: #6569

@fmarier
Copy link
Member

fmarier commented Nov 19, 2019

Related: #6569

Probably vaguely related, but definitely different since I can't repro #6569 but I can repro this issue 100% of the time.

@fmarier
Copy link
Member

fmarier commented Nov 20, 2019

Hm, I have working "clickable" notifications on my work laptop (Brave 1.1 beta, Ubuntu 18.04, dunst 1.3.0-2) but not on my personal laptop (Brave 1.0 release, Debian unstable, dunst 1.4.1-1), both using "dunst" as the notification daemon. I wonder whether it has something to do with how my default browser is setup.

@tmancey
Copy link
Contributor

tmancey commented Nov 23, 2019

@fmarier I am installing Ubuntu 19.10 to test. With regards to Debian @bsclifton do we officially support?

@tmancey
Copy link
Contributor

tmancey commented Nov 25, 2019

I have tested ad notifications on Ubuntu 19.10 and they are working as expected (I have not tested with Dunst, please see below question):

Screenshot 2019-11-25 at 11 23 51

@bsclifton @fmarier @alexwykoff @jsecretan should we be supporting third party notification plug-ins?

@fmarier
Copy link
Member

fmarier commented Nov 25, 2019

@bsclifton @fmarier @alexwykoff @jsecretan should we be supporting third party notification plug-ins?

I moved my issue to #7089 since it is separate from supporting the default notification manager on Ubuntu.

@atharvan
Copy link
Author

After brave 1.1.22 update its working for me.

Brave 1.1.22 Chromium: 79.0.3945.79 (Official Build) (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Linux
JavaScript V8 7.9.317.31

@fmarier
Copy link
Member

fmarier commented Dec 18, 2019

Thanks for the confirmation @atharvan . It also works for me so I'm going to close this issue.

@fmarier fmarier closed this as completed Dec 18, 2019
@vip20
Copy link

vip20 commented Mar 11, 2020

Same issue exists again in
Version 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
with Ubuntu 19.10 #

@tmancey
Copy link
Contributor

tmancey commented Mar 21, 2020

@vip20 Are you using third party notification services?

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants