Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclear what is focused on Tip banner when not enough BAT - follow up to 6147 #6985

Closed
LaurenWags opened this issue Nov 18, 2019 · 3 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #6147

If you do not have enough BAT for the preselected button on the Tip banner, there is no visual indication that the Tip banner is in focus (no buttons show an outline on the banner to indicate focus). However, if you have enough BAT for the pre-selected button, you can see the outline on the Send Tip button indicating that it is in focus on the banner.

Steps to Reproduce

  1. Clean profile on staging, using version 1.1.4
  2. Enable rewards, claim grant.
  3. Visit laurenwags.github.io and open tip banner
  4. See that the Send Tip button has outline.
  5. Close tip banner
  6. Navigate to kjozwiakstaging.github.io and open tip banner.

Note - if you do this with the monthly tip banner instead of one time tip banner, you will encounter #6914

Actual result:

Nothing appears to be in focus. My guess is that the focus is actually on the Send Tip button but it is hidden behind the not enough funds notification banner.
Screen Shot 2019-11-18 at 3 11 48 PM

Expected result:

Something should be focused as the Send Tip button is below.
Screen Shot 2019-11-18 at 3 11 14 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa
cc @mandar-brave @alexwykoff as this relates to tipping efficiency changes

@karenkliu
Copy link

Can we close this since we have a new tip banner? @LaurenWags

@LaurenWags
Copy link
Member Author

@karenkliu let me revisit this one. I think so, but I'd like to double check.

@LaurenWags
Copy link
Member Author

Issue still exists, however tip banner design has changed significantly. Closing this issue in favor of #14595.

@LaurenWags LaurenWags added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed QA/Test-Plan-Specified QA/Yes feature/rewards priority/P4 Planned work. We expect to get to it "soon". labels Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
Projects
None yet
Development

No branches or pull requests

3 participants