Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm spell check works (multiple languages) #726

Closed
bsclifton opened this issue Aug 9, 2018 · 20 comments
Closed

Confirm spell check works (multiple languages) #726

bsclifton opened this issue Aug 9, 2018 · 20 comments
Labels
browser-laptop-parity closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/spell-check l10n

Comments

@bsclifton
Copy link
Member

I believe the setting for this was disabled when solving #512 (with brave/brave-core#244). It's hard for me to tell if spelling corrections are coming from my operating system (macOS) or from Brave Core

browser-laptop supports multiple languages:
screen shot 2018-08-09 at 1 56 03 pm

@srirambv
Copy link
Contributor

@F0rt1s
Copy link

F0rt1s commented Dec 10, 2018

Still disabled in the latest release:
image

@Brave-Matt
Copy link

Still disabled for languages other than English (US) in release build (v0.58.18). +1 from Community:
https://community.brave.com/t/brave-spell-check-in-other-languages/41378

@Musiphilos
Copy link

Still not working on 2020. Spell check in non-English dictionaries is a vital feature for me.

@tobwen
Copy link

tobwen commented Mar 12, 2020

Same here: Version 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)

I wonder what's more important in a modern browser: spelling support for human input or a crypto wallet?!

@marcNY
Copy link

marcNY commented May 10, 2020

Is that issue fixed? I am not able to get spell suggestions for French but I have them for English.

@tobwen
Copy link

tobwen commented May 15, 2020

Nope, still no German dictionary (and maybe others missing, too) .

@oliver-thirtyone
Copy link

Still not working in 2021 😞
I just moved my mail, calendar and note tabs to Brave and I'm very surprised that this feature is lacking.
This might be (the only) reason I won't use the Brave browser...

@FrancoisMentec
Copy link

This is perfectly working for me right now:
image
As you can see in this screenshot, I have spell checking enabled for both English and French, and it's working just fine.
This issue should be closed.

@sergeG
Copy link

sergeG commented Jun 3, 2021

What version of Brave do I need to have working spell check?

As you can see in this screenshot, I have spell checking enabled for both English and French, and it's working just fine.
This issue should be closed.

@tobwen
Copy link

tobwen commented Jun 3, 2021

What version of Brave do I need to have working spell check?

I'm in v1.25.68 and do have German spell checking now. But I cannot add additional languages, like English. This is shown in the screenshot of @FrancoisMentec

@sergeG
Copy link

sergeG commented Jun 3, 2021

OK, I succeed to add American English to my default Russian

It seems that general "English" do not have a dictionary.

Brave Version 1.25.68 Chromium: 91.0.4472.77 (Official Build) (64-bit), linux

@Tonev
Copy link
Contributor

Tonev commented Jun 6, 2021

The default English language at brave://settings/languages doesn't have its own dictionary. You have to manually add "English (United States)" and/or "English (United Kingdom)" if you want a spell check support for either or both of them.

@vokiel-too
Copy link

vokiel-too commented Jun 16, 2021

Brave Version Version 1.25.72 Chromium: 91.0.4472.101

This is simply not working.

image

@FrancoisMentec
Copy link

@vokiel-too all languages don't have spell check, I have no idea why it's like this, or where you can find a list of the ones which does. If you want spellcheck for french you can use regular french or French (France), and for English, you can use English (US).

@vokiel-too
Copy link

@FrancoisMentec I see, this is a UI issue, you don't even see the English (US) enable/disable check until you add a language with an associated dictionary. The Spell check list needs to be displayed at all time, regardless of the languages set above imho

image

@BishopWolf
Copy link

Where do you find the add language thing??

image

@FrancoisMentec
Copy link

@BishopWolf Click on "Idioma", it should show your languages and the "Add languages" button.

@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Feb 28, 2024
@bsclifton
Copy link
Member Author

This should be good to go 😄 As users have noted, you have to add the languages in the settings page. There is then a spell check option and which languages to do spell check for

@FrancoisMentec
Copy link

Hello @bsclifton
This is an old issue, so I do not remember everything, and stuff may have changed since. But the issue is more with the UI than the spellcheck itself. It is unclear in the interface that you have to add languages to enable spell check for them. Many people assume that adding languages is for translating the interface and that it has nothing to do with spellcheck. Also, some languages do not support spellcheck, this should be indicated. For example, Windows shows icons on languages to indicate what is supported:
image
I do not think this issue needs to be re-opened, but a different issue specifically targeting the UI should be IMHO. Just my grain of salt.
Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/spell-check l10n
Projects
None yet
Development

No branches or pull requests